Skip to content

fix(font): avoid serializing full p5.Font data in previewEntry and IDE hook #3461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lirenjie95 wants to merge 1 commit into from
Closed

fix(font): avoid serializing full p5.Font data in previewEntry and IDE hook #3461

lirenjie95 wants to merge 1 commit into from

Conversation

@lirenjie95
Copy link

@lirenjie95 lirenjie95 commented Apr 23, 2025 •
edited
Loading

Fixes #3441

Changes:

  • In previewEntry.js, add handleP5Font to extract only essential fields instead of the entire font data.
  • In useHandleMessageEvent.js, update restoreP5Font to reconstruct a simplified font‐like object for console display.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@welcome
Copy link

welcome bot commented Apr 23, 2025

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

@lirenjie95 lirenjie95 force-pushed the fix/stringify branch 6 times, most recently from f81ad2a to 058c81c Compare April 29, 2025 02:34
@raclim
Copy link
Collaborator

raclim commented Apr 29, 2025

Thanks so much for your patience and for looking into this @lirenjie95!

I think working within the two files, useHandleMessageEvent.js and previewEntry.js make sense to me so far. On a manual testing front, I'm still encountering the error on my end—if there's anything you think I might be missing, or if you happen to have any screenshots or a video of your process, feel free to share!

Also as a heads up: we may end up merging (#3424) first since it came in earlier. That one might cause some merge conflicts with this PR. If you have any thoughts on that PR, whether in general or in relation to your work here, please feel free to weigh in!

@lirenjie95 lirenjie95 force-pushed the fix/stringify branch 2 times, most recently from c8e47b1 to 9672262 Compare May 7, 2025 13:30
@lirenjie95 lirenjie95 marked this pull request as draft May 7, 2025 13:31
@lirenjie95 lirenjie95 force-pushed the fix/stringify branch 4 times, most recently from 4dacee4 to c639739 Compare May 14, 2025 13:01
@lirenjie95 lirenjie95 closed this May 27, 2025
@lirenjie95 lirenjie95 deleted the fix/stringify branch May 27, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Attempting to stringify large variable results in an error log

2 participants

@lirenjie95 @raclim